Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR]: Use js_image_layer with multiple js_binaries with node_modules and other files deduplicated #2002

Open
thesayyn opened this issue Oct 25, 2024 · 1 comment
Open

[FR]: Use js_image_layer with multiple js_binaries with node_modules and other files deduplicated #2002

thesayyn opened this issue Oct 25, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@thesayyn
Copy link
Member

What is the current behavior?

Currently, js_image_layer only allows one js_binary.

Describe the feature

js_image_layer needs to allow passing multiple binaries at once
@thesayyn thesayyn added the enhancement New feature or request label Oct 25, 2024
@thesayyn
Copy link
Member Author

Current workaround is no use sh_binary and add js_binaries into data to allow bazel to deduplicate files for us and put that into js_image_layer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thesayyn