Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Source Deletion Bug #3

Open
AwesomestCode opened this issue Jan 22, 2025 · 0 comments
Open

Open Source Deletion Bug #3

AwesomestCode opened this issue Jan 22, 2025 · 0 comments

Comments

@AwesomestCode
Copy link

I found a bug in the handling of deletions while doing some testing that I think is causing download failures.

Steps to reproduce:

  1. Connect to network with slow/spotty internet. Or, simulate spotty internet access using Chrome DevTools's Network tab.
  2. Attempt to disclose a round with an open source document. Press add round. Notice that sometimes the round doesn't immediately go through.
  3. Press add round again before the first addition succeeds and redirects you to the team page (as a confused user might do thinking that the first addition failed).
  4. After you're redirected to the team page with both attempts having gone through, notice that the same round is disclosed twice.
  5. Delete one of the two disclosures to avoid duplication of the round on the team page.
  6. Attempt to download the open source doc on the remaining disclosure. Notice that it errors out.

Potential solutions:

  • Disable the add round button immediately after it's clicked (and display a loading icon), preventing accidental duplication of rounds.
  • Check to make sure there's no round with identical round details server-side when a new disclosure is posted. If there is, fail the disclosure.
  • Generate a unique ID for each round's open source doc so deleting one doesn't cause the other one to also get deleted.

If you want me to PR one of these solutions, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant