-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to control where prose indent is applied #2034
Comments
Can you point me a book that uses this style so that I can study it? |
Can you cite which book that is an in which reader you are using to view it? |
I found two references for this rule, which seems to be called "full out indent". |
Both Chicago and APA require the indentation on the first paragraph, so there are clearly two styles. As far as the code is concerned, we do have the ability to check if the previous sibling is a paragraph, so technically its possible to support. Though we do need to decide how this is going to be expressed in the theme. To keep with the CSS theme, we could using something like |
I also found this reference on MDN: https://developer.mozilla.org/en-US/docs/Web/CSS/text-indent#skipping_indentation_on_the_first_paragraph |
…ent paragraph if prose-adjacent-text-indent key is set in theme
Here's what I propose. If prose:
margin-inner: 0
adjacent-text-indent: 10.5 Does that sound reasonable? |
Thanks for all this research, Dan. Happy to let you decide here, as you're by far more intimate in how the inter-relationship of configured properties works in other places already. |
Thanks for the feedback Oliver. I was thinking that since we use the term "inner" to refer to the margin between adjacent paragraphs, we should stick with that terminology here as well. That could help make the key more intuitive. prose:
margin-inner: 0
inner-text-indent: 10.5 Unless there is an objection, I'll move forward with this proposal. |
…ent paragraph if prose-adjacent-text-indent key is set in theme
When coming back to this with fresh eyes, I realized that the placement of the "inner" keyword is not consistent between the two terms, which could be confusing. I propose making it parallel: prose:
margin-inner: 0
text-indent-inner: 10.5 The |
That looks great! Thanks for sharing! |
I have a tiny follow-up for this one: Asciidoctor Bibtex extension renders each entry as paragraph, which now causes all entries but the first one to be indented (see below). I fully understand why it renders the way it renders and am afraid that it's hard to fix without Bibtex fundamentally changing the way it renders the entries. Do you see a short-term workaround accidentally? |
As I've expressed before, asciidoctor-bibtex should be generating the bibliography as a list, not as separate paragraphs. If that extension were producing a list, you would not get this behavior. |
Using asciidoctor/asciidoctor-bibtex#84 as a hacky workaround for now. |
Defining a
prose.indent
property causes the first line of every paragraph indented. However, in books that first line indentation is often skipped for the first paragraph after a heading, table, image, i.e. if the preceding content element is not a paragraph in turn.It would be nice if one could choose between these application modes of the setting.
The text was updated successfully, but these errors were encountered: