-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addresses cases where 'parentNetwork' value is not an RA acronym in station's DS response #158
Comments
@abirger, @cheryldmorse and I are defining the next milestone. Do we need to revisit this issue? The crosswalk indicates that institution should be used to define parentNetwork. What happens in the institution is not an RA acronym? |
@kknee , @cheryldmorse , formally, ncSOS will fail the describeSensor:IOOS-SOS.DescribeSensor- ResponseContainsValidOperationsMetadataProperty.6, which follows the IOOS Convention requirement for parentNetwork, if the parentNetwork does not contain RA acronym and IOOS codeSpace. |
Here's my logic from trying to step through the documentation to answer this question... It seems to me that from the SOS SensorML guidelines, we require SensorML responses to return the following <sml:classifier> elements:
Of these, the relevant classifiers to this issue are 'parentNetwork', 'publisher', and 'sponsor' as each of these are of the type 'organization' in the MMISW codespace http://mmisw.org/ont/ioos/organization. From the IOOS vocabulary definitions:
Aside: why do we not require an 'operator' classifier in the SensorML as well (see SensorML guidelines )? Instead, 'operator' is a required <sml:contact> element, mapped from the 'creator_name' netCDF attribute according to the netCDF/SOS crosswalk. It seems it also belongs as another classifier. Maybe it was overlooked? A separate issue beside the point of this a bit, just wanted to mention it. Unless I misunderstand, each of the 'parentNetwork', 'publisher' and 'sponsor' is required to be one of the values of 'organization' as defined here: http://mmisw.org/ont/ioos/organization in order to pass the conformance tests. So 'sponsors' can only be among the valid organizations in this list? Seems a bit restrictive. I see a few problems:
What is the difference?? Should something other than 'institution' be mapped to 'parentNetwork'? How about 'publisher_name', which currently maps to the <sml:classifier>@name='publisher')? I'm sure this was debated before, but in my thinking 'parentNetwork' is probably more often going to be the data publisher than the 'institution responsible for originating' the data. It should really be a an IOOS-specific netCDF Profile attribute (eg 'parentNetwork') but I don't think changing the required attribution is a path we want to go down at this point probably. cc: @dpsnowden @kbailey-noaa @emiliom </end rant> |
@mwengren , it’s too late today to start digging but as far as I remember, the “required” elements are (1) the elements that are defined as “globally mandatory” ones by the relevant OGC schemata + (2) the “globally optional” elements that IOOS stockholders considered worthy of being “community mandatory” for IOOS. There is nothing sacral in the second part, just the stockholder’s ideas at the moment when the IOOS SOS v1.0 was discussed. We can review and modify the second part anytime as SMEs think fit. |
As a followup, I discovered today that ncISO has the following mappings in ISO:
This means that in ncISO This differs from our netCDF to SOS mappings table, where So we will always be inconsistent in our SensorML metadata and the ISO XML produced by ncISO for netCDF files that use ncSOS, unless either of these change. If however
Another smaller problem is that all of the ISO metadata from THREDDS/ncISO in our Catalog has We may want to consider making use of the
|
comments from @cheryldmorse
"I’ve updated the code so that the ‘parentNetwork’ is not empty for the network’s DS response (failure #1) as long as the ‘institution’ attribute exists in the NetCDF file. But ncSOS will still fail this requirement because the ‘parentNetwork’ may be set to a value that is not a RA acronym. In the NetCDF files that Alex used for his test cases the ‘institution’ attribute was set to a value of ‘Weatherflow Inc.’ which means that the ‘parentNetwork’ was set to ‘WeatherFlow Inc.’ and ncSOS failed the test case. How should we proceed when the ‘institution’ attribute is missing or set to a value that is not a RA acronym?"
and from @abirger
"My thought is that we should minimize the changes for now so we could complete the Milestone 1.0 at last, even with some non-critical flaws. Therefore, I believe that it would be quite satisfactory for now, if ncSOS could use for the ‘parentNetwork’ a value from a netCDF ‘institution’ attribute, and ensure that the ‘parentNetwork’ field is not empty in case the attribute is missing.
We should definitely resume discussion about this and other issues later within Milestone 2.0 framework."
The text was updated successfully, but these errors were encountered: