Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early checks for constructor argument incompatibilities #250

Open
cle-ros opened this issue Feb 20, 2020 · 2 comments
Open

Early checks for constructor argument incompatibilities #250

cle-ros opened this issue Feb 20, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@cle-ros
Copy link
Contributor

cle-ros commented Feb 20, 2020

Is your feature request related to a problem? Please describe.
Given that an experiment can take a long time to get to the latest object initialization step, any incompatibilities of arguments to the constructors should be caught as early as possible.

Describe the solution you'd like
I think that flambe.component should have a classmethod check_constructor_args(*args, **kwargs) that's automatically called very early after starting an experiment. This would offer the option to override that method, so that any kind of exception could be raised very, very early in the experiment's pipeline.

@cle-ros cle-ros added the enhancement New feature or request label Feb 20, 2020
@nmatthews-asapp
Copy link
Contributor

@jeremyasapp I propose we have some kind of test run functionality that initializes all objects but doesn't run them, as that will cover this feature request in a general way that doesn't require additional non-standard functions from users

@jeremyasapp
Copy link
Contributor

@nmatthews-asapp I like the idea. I can try to make a PR for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants