Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datafile is opened without close function #20

Open
youyuge34 opened this issue Oct 23, 2017 · 1 comment
Open

datafile is opened without close function #20

youyuge34 opened this issue Oct 23, 2017 · 1 comment

Comments

@youyuge34
Copy link

Inside the function dataFromFile(fname) ,the file is opened. But the file close function is not called, which is not safe. Suggest that call the with open...as... instead of open function.
@zoeleesss
Copy link

I have implemented this lift feature with more datasets. See my repo here:
https://github.com/zoeleesss/Apriori

muety added a commit to muety/Apriori that referenced this issue Oct 3, 2018
@muety
Fix asaini#11, asaini#13 and asaini#20 and add Python3 support tp apr…
c240f2a 
…iori script.
asaini added a commit that referenced this issue Jan 22, 2019
@asaini
Merge pull request #27 from n1try/master
796b1db 
Fix #11, #13 and #20 and add Python3 support to apriori script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@youyuge34 @zoeleesss