Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VM/exec] Leakless blocks not working properly with pre-defined functions #1219

Open
github-actions bot opened this issue Jun 14, 2023 · 2 comments
Open
Labels
bug Something isn't working critical Critical, top-priority issues execution Issues related to the executor (src/vm/exec.nim) library Issues related to the standard library todo Automatically generated issues from TODOs in the code vm Issues related to the Virtual Machine implementation

Comments

@github-actions
Copy link

[VM/exec] Leakless blocks not working properly with pre-defined functions
Let's say we have a pre-defined function (e.g. arg) and this symbol is used
as an iterator variable - which is precisely where leakless blocks come into play -
this creates a total mess, since their arities are not properly handled.
e.g.

for arr 'arg [ 
; do sth
]

Also see: https://github.com/arturo-lang/arturo/blob/master/examples/rosetta/call%20a%20function.art
and https://github.com/arturo-lang/arturo/blob/master/examples/rosetta/variadic%20function.art

# TODO(VM/exec) Leakless blocks not working properly with pre-defined functions

        pop()

# TODO(VM/exec) Leakless blocks not working properly with pre-defined functions
#  Let's say we have a pre-defined function (e.g. `arg`) and this symbol is used
#  as an iterator variable - which is precisely where leakless blocks come into play -
#  this creates a total mess, since their arities are not properly handled.
#  e.g.
#  ```
#  for arr 'arg [ 
#      ; do sth
#  ]
#  ```
#  Also see: https://github.com/arturo-lang/arturo/blob/master/examples/rosetta/call%20a%20function.art
#  and https://github.com/arturo-lang/arturo/blob/master/examples/rosetta/variadic%20function.art
#  labels: bugs, critical, library, vm, execution

template prepareLeakless*(protected: seq[string] | ValueArray): untyped =
    ## Prepare for leak-less block execution

ndex c99bf43de1..bbf2b7302e 100644
++ b/version/build

69bbd8fae3ea724ead6422700b83908a18c78422

@github-actions github-actions bot added critical Critical, top-priority issues execution Issues related to the executor (src/vm/exec.nim) library Issues related to the standard library todo Automatically generated issues from TODOs in the code vm Issues related to the Virtual Machine implementation bugs labels Jun 14, 2023
@drkameleon drkameleon added bug Something isn't working and removed bugs labels Nov 6, 2023
Copy link

stale bot commented Jul 3, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 3, 2024
Copy link

stale bot commented Nov 5, 2024

Closing issue as stale.

@stale stale bot closed this as completed Nov 5, 2024
@RickBarretto RickBarretto reopened this Jan 6, 2025
@stale stale bot removed the stale label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical Critical, top-priority issues execution Issues related to the executor (src/vm/exec.nim) library Issues related to the standard library todo Automatically generated issues from TODOs in the code vm Issues related to the Virtual Machine implementation
Projects
None yet
Development

No branches or pull requests

2 participants