Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fake_ebola_genome.fasta is not present in repo #8

Open
trvrb opened this issue Sep 29, 2018 · 2 comments
Open

fake_ebola_genome.fasta is not present in repo #8

trvrb opened this issue Sep 29, 2018 · 2 comments

Comments

@trvrb
Copy link
Contributor

trvrb commented Sep 29, 2018

@rambaut ---

The phylogenetics SOP refers to a file fake_ebola_genome.fasta:

fake_ebola_genome.fasta is an artificial genome sequence constructed to fall within the diversity of the 35 provided reference genomes to simulate the discovery of a new lineage of EBOV.

(This reference is here: https://github.com/artic-network/artic-ebov/blob/master/pages/ebov-phylogenetics-sop.md#test-data)

However, no such file exists in the artic-ebov repo.

@rambaut
Copy link
Member

rambaut commented Sep 30, 2018

Good catch, @trvrb. @plemey made this sequence originally as an idea but I am a little bit nervous of it making it out into the 'wild' as it were even though it is clearly labelled.

I removed it in commit 0572b79

Will leave this issue open to update the SOP (which we need to do anyway).

@trvrb
Copy link
Contributor Author

trvrb commented Oct 1, 2018

Sounds great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants