Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query ImageMagick for a valid color names #16

Open
elfenlaid opened this issue Jun 22, 2020 · 0 comments
Open

Query ImageMagick for a valid color names #16

elfenlaid opened this issue Jun 22, 2020 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed

Comments

@elfenlaid
Copy link
Contributor

While reviewing #14 @BenLeggiero raised an interesting opportunity I can't miss discussing :)

Badgy carries a hardcoded color names for --color and --tint-color properties.
Alternatively, we could query ImageMagick for the list with convert -list color | awk '{ print $1 }'.

Each solution has its pros and cons. Unfortunately, both are prone to get out of sync with the end-user scripts, as we have an unpinned dependency on ImageMagick.

All in all, it seems like a hardcoded list looks like a bit easier to reason about considering runtime and dependency validation.
Even as Badgy is destined to go out of sync with ImageMagick named colors right now, we always have an escape hatch with hexed color codes.

@arthurpalves arthurpalves added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 22, 2020
@arthurpalves arthurpalves added the help wanted Extra attention is needed label Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants