reactive_touch_spin doesn't display programmatic value updates

[benji-farquhar]

reactive_touch_spin only displays updated values from clicking the up and down arrows to change the number, not from resetting the form values or calling updateValue() or any of the other numerous ways of changing the value programmatically using reactive_forms.

[benji-farquhar]

To recreate - edit the example app - example/lib/main.dart and make the sign up button update the value:

ElevatedButton(
  child: const Text('Sign Up'),
  onPressed: () {
    if (form.valid) {
      // ignore: avoid_print
      form.control('touchSpin').updateValue(50);
      print(form.value);
    } else {
      form.markAllAsTouched();
    }
  },
),

[benji-farquhar]

I don't think you'll be able to use flutter_touch_spin due to this issue.

It kind of makes the widget, not a reactive_forms widget as it is unresponsive to reactive_forms.

[vasilich6107]

Hi @BenjaminFarquhar
Thanks for investigating.

It seems that I will need to make PR one more time and release a temp substitution for the control)
After making PR i will ask you to tag the maintainer for releasing an update.

[benji-farquhar]

@vasilich6107 You're welcome! Sounds good! Sure, will do.

[vasilich6107]

@BenjaminFarquhar done
Let's tag the maintainer)

[vasilich6107]

danvick/flutter_touch_spin#14

[vasilich6107]

@BenjaminFarquhar check latest version

[benji-farquhar]

@vasilich6107 I will do thank you. I have confirmed it is working. Thanks for the quick fix.

[benji-farquhar]

@vasilich6107 in version 0.4.0 I get the error:

setState() or markNeedsBuild() called during build.

When I go back to ^0.3.0-nullsafety.2 I don't get the error. I don't have time right now to investigate so I'm staying on ^0.3.0-nullsafety.2 as everything is working fine for me on that - changing the value from the outside is also working in that version.

[vasilich6107]

Could you provide reproduction code?

[benji-farquhar]

@vasilich6107 The bug occurs when you run the example project and click on the + or - in the widget with the mouse

[vasilich6107]

@BenjaminFarquhar
here is my PR updates

here is what inside

[vasilich6107]

I do not know why author added setState call

[vasilich6107]

@BenjaminFarquhar

From flutter docs

The framework always calls [build](https://api.flutter.dev/flutter/widgets/State/build.html) after 
calling [didUpdateWidget](https://api.flutter.dev/flutter/widgets/State/didUpdateWidget.html), 
which means any calls to [setState](https://api.flutter.dev/flutter/widgets/State/setState.html) in [didUpdateWidget]
(https://api.flutter.dev/flutter/widgets/State/didUpdateWidget.html) are redundant.```