Problem: Old PDF page display functionality exists in AtoM's code, but doesn't work

[mcantelon]

Current Behavior

Here are the steps needs to enable the setting and upload a PDF:

1. Navigate to settings/uploads.
2. Change the "Upload multi-page files as multiple descriptions" setting to "Yes".
3. Click the "Save" button.
4. Navigate to informationobject/add and add an information object.
5. Once you've created the information object then, for the "More" select menu, select "Link Digital Object".
6. Click "Choose file", select a multi-page PDF file, then click the "Create" button.
7. An information object for the PDF, with child information objects representing each page, should now have been added.

The image below shows how it's currently displayed. There's an image carousel, containing images for each page, that's not part of the old PDF page navigation code. And there's an area, highlighted with a red square, where parts of the old PDF page navigation are displayed.

Expected Behavior

Using a branch I created to make the old functionality work again (https://github.com/artefactual/atom/tree/dev/fix-old-pdf-handling), I was able to show how the old PDF page navigation looks. Note that the image carousel redundantly also shows above the PDF navigator.

Whether we want to make the old functionality work again, though, is something we'll need to decide.

Possible Solutions

One solution could be to remove the old PDF page navigation code.

Another could be to keep it, but fix it. I've roughed out a fix branch (which shows PDF pages in both the new style image carousel and the old PDF page navigation so we'd probably want to add logic to suppress the image carousel when showing PDF pages):

https://github.com/artefactual/atom/tree/dev/fix-old-pdf-handling

Context and Notes

Users occasionally need this functionality.

Version used

2.8.2 - 193

Operating System and version

Ubuntu 22.04

Default installation culture

en

PHP version

7.4

Contact details

[email protected]