Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: middleware to append trailing slash should not be needed #13

Closed
sevein opened this issue Jul 23, 2024 · 0 comments · Fixed by #17
Closed

Problem: middleware to append trailing slash should not be needed #13

sevein opened this issue Jul 23, 2024 · 0 comments · Fixed by #17

Comments

@sevein
Copy link
Member

sevein commented Jul 23, 2024

We started using appendTrailingSlashHandler because @typespec/http was unable to describe paths with a trailing slash, but it was fixed in v0.58.0. However the trailing slash is also dropped by Kiota when generating the Go client, see microsoft/kiota#4291 for more details. We'll have to rely on the middleware while this issue exists.

sevein added a commit that referenced this issue Oct 17, 2024
This commit fixes #13 since kiota 1.19.0 included the fix with trailing slashes
in the OpenAPI.NET repo (release 1.6.22). `appendTrailingSlashHandler` is
removed because the generated client is now including trailing slashes as
expected by Archivematica Storage Service.
sevein added a commit that referenced this issue Oct 17, 2024
This commit fixes #13 since kiota 1.19.0 included the fix with trailing slashes
in the OpenAPI.NET repo (release 1.6.22).

`appendTrailingSlashHandler` is removed because the generated client is now
including trailing slashes as expected by Archivematica Storage Service. All
tests under the root and example modules are passing with the handler removed.
sevein added a commit that referenced this issue Oct 17, 2024
This commit fixes #13 since kiota 1.19.0 included the fix with trailing slashes
in the OpenAPI.NET repo (release 1.6.22).

`appendTrailingSlashHandler` is removed because the generated client is now
including trailing slashes as expected by Archivematica Storage Service. All
tests under the root and example modules are passing with the handler removed.
@sevein sevein closed this as completed in 38ba022 Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant