Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Inline functions create additional anonymous class declaration #19

Open
pakoito opened this issue Aug 1, 2018 · 5 comments
Open

Inline functions create additional anonymous class declaration #19

pakoito opened this issue Aug 1, 2018 · 5 comments
Assignees

Comments

@pakoito
Copy link
Member

pakoito commented Aug 1, 2018

Each inline declaration of a function, i.e. pipe, it may force callsites to create an anonymous class to capture the scope. This is an issue in Android land, due to the dex format and its limitations around method count and size.

If we can validate this assumption in the bytecode viewer, it's worth consider doing a pass on the codebase and remove many unnecessary inline annotations.

What'cha think.

@MarioAriasC
Copy link
Member

I'll have a look

@Laimiux
Copy link
Contributor

Laimiux commented Aug 30, 2018

Is there any update on this?

@pakoito
Copy link
Member Author

pakoito commented Aug 31, 2018

I did a pass on some of the core datatypes: arrow-kt/arrow#971

For arrow-syntax we'll do it if necessary.

@Laimiux
Copy link
Contributor

Laimiux commented Sep 7, 2018

I think it would be valuable to remove inline at least from pipe and partially functions (at least from our use cases). I could do a pass on arrow-syntax.

@pakoito
Copy link
Member Author

pakoito commented Sep 7, 2018

Go for it, thanks!

@rachelcarmena rachelcarmena transferred this issue from arrow-kt/arrow Feb 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants