Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing @DockerRequired #44

Open
jasondlee opened this issue Nov 19, 2024 · 1 comment
Open

Consider removing @DockerRequired #44

jasondlee opened this issue Nov 19, 2024 · 1 comment

Comments

@jasondlee
Copy link
Collaborator

The @DockerRequired annotation is likely not needed. The point of this module is to support lifecycle control and injection of Testcontainer instances, so Docker (or Podman) being required is implied. We should be able to remove this annotation, then, and perform any container-readiness checks during the injection handling.

@jamezp
Copy link
Collaborator

jamezp commented Nov 19, 2024

The one place, and maybe there is a workaround, where the annotation is beneficial is to fail-fast. However, I'm not sure how critical that is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants