Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change annotation name #43

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

jasondlee
Copy link
Collaborator

Rename DockerRequired to ContainerRequired
Clean up stray references to "docker"

Resolves #39.

Rename DockerRequired to ContainerRequired
Clean up stray references to "docker"
@jasondlee jasondlee requested a review from jamezp November 18, 2024 17:58
@rhusar rhusar self-requested a review November 18, 2024 18:27
Copy link
Collaborator

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping to some aggressive discussion/voting on that issue. I have to say my favorite is @ContainerRuntimeRequired.

@jasondlee
Copy link
Collaborator Author

I was hoping to some aggressive discussion/voting on that issue. I have to say my favorite is @ContainerRuntimeRequired.

And we can have that. :) I just pushed this so I didn't lose the changes I had locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better name for @DockerRequired
2 participants