Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TomEE profile: switch to TomEE 10 M3, wildfly-arquillian-container 5.0.1 #243

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

WolfgangHG
Copy link
Contributor

Partially resolves #242: TomEE 10 is JakartaEE10 compliant, but not final. More details in this issue.

Also updates the constant "version.wildfly.arquillian.container" to "5.0.1.Final" (don't know why dependabot did not pick it).

Copy link
Collaborator

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting to look good - but needs enabling CI changing these lines:

https://github.com/arquillian/arquillian-extension-warp/blob/main/.github/workflows/ci.yml#L30-L31

@WolfgangHG
Copy link
Contributor Author

@rhusar About enabling the profile: see my comment in #242 - this is not possible due to the HtmlUnit error.

@WolfgangHG WolfgangHG requested a review from rhusar October 16, 2024 17:49
@rhusar
Copy link
Collaborator

rhusar commented Oct 16, 2024

FYI debugging the dependabot:

2024-10-16T12:48:46.3256130Z updater | 2024/10/16 12:48:46 INFO <job_902042634> Latest version is 5.0.1.Final
2024-10-16T12:48:46.3262664Z updater | 2024/10/16 12:48:46 INFO <job_902042634> Pull request already exists for org.wildfly.arquillian:wildfly-arquillian-container-remote with latest version 5.0.1.Final

it's because it originally opened
#141

which we had to ignore:
#208

So, it will work for future versions.

@rhusar
Copy link
Collaborator

rhusar commented Oct 16, 2024

@rhusar About enabling the profile: see my comment in #242 - this is not possible due to the HtmlUnit error.

Uh... I see. We cannot merge this without the rest of the tests running. Just add a quick temporary solution to skip the test on tomee:

@BeforeClass
public static void beforeClass() throws IOException, InterruptedException {
    Assume.assumeFalse( here check for the tomee system property );
}

@WolfgangHG
Copy link
Contributor Author

Do you mean something like this (didn't know what to check for, so I guessed ;-))?

    @BeforeClass
    public static void beforeClass() throws IOException, InterruptedException {
       String tomEEHome = (String) System.getProperty("tomee.home");
       
       Assume.assumeTrue(tomEEHome == null || tomEEHome.length() == 0);
    }

This would only make sense if you can start the TomEE tests with Java 17 and avoid Java 11 here.

@rhusar
Copy link
Collaborator

rhusar commented Oct 16, 2024

Do you mean something like this (didn't know what to check for, so I guessed ;-))?

    @BeforeClass
    public static void beforeClass() throws IOException, InterruptedException {
       String tomEEHome = (String) System.getProperty("tomee.home");
       
       Assume.assumeTrue(tomEEHome == null || tomEEHome.length() == 0);
    }

Something like that, whatever works.

This would only make sense if you can start the TomEE tests with Java 17 and avoid Java 11 here.

That needs to be excluded completely in GitHub Actions:
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/running-variations-of-jobs-in-a-workflow#excluding-matrix-configurations

@WolfgangHG
Copy link
Contributor Author

Something like this in "ci.yml"?

  ci:
    runs-on: ${{ matrix.os }}
    timeout-minutes: 30
    strategy:
      fail-fast: false
      matrix:
        os:
          - ubuntu-latest
        # Keep this list as: all supported LTS JDKs, the latest GA JDK, and the latest EA JDK (optional).
        java:
          - 11
          - 17
          - 21
          - 23
        container:
          - wildfly-managed
          # TODO GlassFish 5 is not compatible with JDK 9 and newer
          # - glassfish-managed
           - tomee-managed
        exclude:
           - os: ubuntu-latest
             java: 11
             container: tomee-managed

@rhusar
Copy link
Collaborator

rhusar commented Oct 16, 2024

Something like this in "ci.yml"?

  ci:
    runs-on: ${{ matrix.os }}
    timeout-minutes: 30
    strategy:
      fail-fast: false
      matrix:
        os:
          - ubuntu-latest
        # Keep this list as: all supported LTS JDKs, the latest GA JDK, and the latest EA JDK (optional).
        java:
          - 11
          - 17
          - 21
          - 23
        container:
          - wildfly-managed
          # TODO GlassFish 5 is not compatible with JDK 9 and newer
          # - glassfish-managed
           - tomee-managed
        exclude:
           - os: ubuntu-latest
             java: 11
             container: tomee-managed

That looks correct to me!

@WolfgangHG
Copy link
Contributor Author

Yes, ci is back again ;-). Done for today....

@rhusar rhusar merged commit 62a1d40 into arquillian:main Oct 17, 2024
7 checks passed
@rhusar
Copy link
Collaborator

rhusar commented Oct 17, 2024

Thanks @WolfgangHG !

@WolfgangHG WolfgangHG deleted the tomee10 branch October 17, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore skipped tests in TomEE profile (due to HtmlUnit failure) - was "Restore TomEE support in test suite"
2 participants