-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TomEE profile: switch to TomEE 10 M3, wildfly-arquillian-container 5.0.1 #243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting to look good - but needs enabling CI changing these lines:
https://github.com/arquillian/arquillian-extension-warp/blob/main/.github/workflows/ci.yml#L30-L31
FYI debugging the dependabot: 2024-10-16T12:48:46.3256130Z updater | 2024/10/16 12:48:46 INFO <job_902042634> Latest version is 5.0.1.Final it's because it originally opened which we had to ignore: So, it will work for future versions. |
Uh... I see. We cannot merge this without the rest of the tests running. Just add a quick temporary solution to skip the test on tomee:
|
Do you mean something like this (didn't know what to check for, so I guessed ;-))?
This would only make sense if you can start the TomEE tests with Java 17 and avoid Java 11 here. |
Something like that, whatever works.
That needs to be excluded completely in GitHub Actions: |
Something like this in "ci.yml"?
|
That looks correct to me! |
Yes, ci is back again ;-). Done for today.... |
Thanks @WolfgangHG ! |
Partially resolves #242: TomEE 10 is JakartaEE10 compliant, but not final. More details in this issue.
Also updates the constant "version.wildfly.arquillian.container" to "5.0.1.Final" (don't know why dependabot did not pick it).