Restore testsuite for Glassfish 7, switch to "org.omnifaces.arquillia… #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhusar
approved these changes
Oct 23, 2024
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n" container
Switch to GlassFish 7 (JakartaEE 10 compliant) and https://github.com/OmniFish-EE/arquillian-container-glassfish.
There is one modification to the test "org.jboss.arquillian.warp.jsf.ftest.producer.TestJSFResourceNotFound": the deployed war file requires a "bean.xml", otherwise the test failed with
IllegalStateException: CDI is not availableShould have no impact on other containers.
(Mostly) resolves #131. The file leak problem from this issue still happens on Windows - every test has a delay of 20 seconds when Glassfish waits for locked files. Should not be a problem with Linux. Please keep #131 open until I find time to look into this.
Let's see whether the CI test works again. If it works, this pull request can be merged. If it fails: I will probably not have the time to look into it the next few days.