Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugging defaults to on #82

Open
mattst opened this issue Mar 9, 2019 · 0 comments
Open

Debugging defaults to on #82

mattst opened this issue Mar 9, 2019 · 0 comments

Comments

@mattst
Copy link

mattst commented Mar 9, 2019

I just noticed that ExpandRegion is printing debug data to the console every time I use it.

This is clearly because in the file ExpandRegion.py, the run() method of the ExpandRegionCommand class has its debug parameter defaulting to true.

Since I am familiar with writing ST plugins I was able to stop this in my key bindings with:

{ "keys": ["whatever"], "command": "expand_region", "args": {"debug": false} },

I suggest that you change the run() method's debug parameter so that it defaults to false.

class ExpandRegionCommand(sublime_plugin.TextCommand):
    def run(self, edit, language="", undo=False, debug=False):

To aid users in debugging you could add a debug setting or at least suggest the addition of "args": {"debug": false} in the keys section of README.md so they are aware that debugging can be turned on/off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant