Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Figure out if the board variable FULL_DESKTOP= is still in use #6921

Open
ColorfulRhino opened this issue Jul 8, 2024 · 2 comments
Labels
Help needed We need your involvement Task/To-Do Project management: To-Do or task(s) someone is working on

Comments

@ColorfulRhino
Copy link
Collaborator

Task description

Many boards use the variable FULL_DESKTOP= in their board config. I can't seem to find a reference in the code though. This is from the readme:

- **FULL_DESKTOP** ( boolean ): defines whether to install desktop stack of applications such as office, thunderbird, etc..
- Values:
- yes: install desktop stack
- no: doesn't install desktop stack

On the contrary, the HAS_VIDEO_OUTPUT variable seems more important and is actually referenced in the code. Maybe we should replace all occurrencs of FULL_DESKTOP with HAS_VIDEO_OUTPUT?

- **HAS_VIDEO_OUTPUT** ( boolean ): defines whether the system has video output such as eye candy, bootsplash, etc..
- Values:
- yes: Enable video-related configuration
- no: Disable video-related configuration

@ColorfulRhino ColorfulRhino added Help needed We need your involvement Task/To-Do Project management: To-Do or task(s) someone is working on labels Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

Jira ticket: AR-2414

@rpardini
Copy link
Member

Hmm. I think at least one, if not both, of those variables are actually used in the JSON matrix for the build pipelines.

That might live somewhere under armbian/os and not here.

It's worth noting that every variable in the board file is exposed to the pipeline JSON if it matches a certain regex; some are further processed, eg, coerced into a JSON boolean.

I think HAS_VIDEO_OUTPUT is specifically used for the auto-inventory stuff:

    items-from-inventory:
      not-eos-with-video: yes # not-eos boards, all branches, only those without HAS_VIDEO_OUTPUT="no"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help needed We need your involvement Task/To-Do Project management: To-Do or task(s) someone is working on
Development

No branches or pull requests

2 participants