From eb2c255de2ef7e5bbe92dc0be0ecdb07a1d2205e Mon Sep 17 00:00:00 2001
From: skaunov <skaunov@disroot.org>
Date: Thu, 8 Feb 2024 04:54:46 +0300
Subject: [PATCH 1/3] Fix visibility of `get_limbs_representations`

(Also additional tiny style fix.)
---
 src/fields/emulated_fp/allocated_field_var.rs | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/fields/emulated_fp/allocated_field_var.rs b/src/fields/emulated_fp/allocated_field_var.rs
index 6905fe37..34825329 100644
--- a/src/fields/emulated_fp/allocated_field_var.rs
+++ b/src/fields/emulated_fp/allocated_field_var.rs
@@ -302,10 +302,10 @@ impl<TargetF: PrimeField, BaseF: PrimeField> AllocatedEmulatedFpVar<TargetF, Bas
         Ok(inverse)
     }
 
-    /// Convert a `TargetF` element into limbs (not constraints)
+    /// Convert a `TargetF` element into limbs (not constraints).
     /// This is an internal function that would be reused by a number of other
-    /// functions
-    pub fn get_limbs_representations(
+    /// functions.
+    pub(super) fn get_limbs_representations(
         elem: &TargetF,
         optimization_type: OptimizationType,
     ) -> R1CSResult<Vec<BaseF>> {
@@ -464,7 +464,7 @@ impl<TargetF: PrimeField, BaseF: PrimeField> AllocatedEmulatedFpVar<TargetF, Bas
         for limb in p_representations.iter() {
             p_gadget_limbs.push(FpVar::<BaseF>::Constant(*limb));
         }
-        let p_gadget = AllocatedEmulatedFpVar::<TargetF, BaseF> {
+        let p_gadget = Self {
             cs: self.cs(),
             limbs: p_gadget_limbs,
             num_of_additions_over_normal_form: BaseF::one(),
@@ -621,10 +621,10 @@ impl<TargetF: PrimeField, BaseF: PrimeField> AllocatedEmulatedFpVar<TargetF, Bas
     }
 
     /// Allocates a new non-native field witness with value given by the
-    /// function `f`.  Enforces that the field element has value in `[0, modulus)`,
-    /// and returns the bits of its binary representation.
-    /// The bits are in little-endian (i.e., the bit at index 0 is the LSB) and the
-    /// bit-vector is empty in non-witness allocation modes.
+    /// function `f`. Enforces that the field element has value
+    /// in `[0, modulus)`, and returns the bits of its binary representation.
+    /// The bits are in little-endian (i.e., the bit at index 0 is the LSB) and
+    /// the bit-vector is empty in non-witness allocation modes.
     pub fn new_witness_with_le_bits<T: Borrow<TargetF>>(
         cs: impl Into<Namespace<BaseF>>,
         f: impl FnOnce() -> Result<T, SynthesisError>,

From 78c4820d5ef64ffe3a3ae18d8acc9e04d5520ad0 Mon Sep 17 00:00:00 2001
From: skaunov <skaunov@disroot.org>
Date: Fri, 9 Feb 2024 23:25:52 +0300
Subject: [PATCH 2/3] Visibility doc update, tiny style fixes

---
 src/fields/emulated_fp/allocated_field_var.rs | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/src/fields/emulated_fp/allocated_field_var.rs b/src/fields/emulated_fp/allocated_field_var.rs
index 34825329..a717ba07 100644
--- a/src/fields/emulated_fp/allocated_field_var.rs
+++ b/src/fields/emulated_fp/allocated_field_var.rs
@@ -303,9 +303,9 @@ impl<TargetF: PrimeField, BaseF: PrimeField> AllocatedEmulatedFpVar<TargetF, Bas
     }
 
     /// Convert a `TargetF` element into limbs (not constraints).
-    /// This is an internal function that would be reused by a number of other
-    /// functions.
-    pub(super) fn get_limbs_representations(
+    /// This is an utility function intended
+    /// to be reused by a number of other functions.
+    pub fn get_limbs_representations(
         elem: &TargetF,
         optimization_type: OptimizationType,
     ) -> R1CSResult<Vec<BaseF>> {
@@ -453,11 +453,10 @@ impl<TargetF: PrimeField, BaseF: PrimeField> AllocatedEmulatedFpVar<TargetF, Bas
         );
 
         // Get p
-        let p_representations =
-            AllocatedEmulatedFpVar::<TargetF, BaseF>::get_limbs_representations_from_big_integer(
-                &<TargetF as PrimeField>::MODULUS,
-                self.get_optimization_type(),
-            )?;
+        let p_representations = Self::get_limbs_representations_from_big_integer(
+            &<TargetF as PrimeField>::MODULUS,
+            self.get_optimization_type(),
+        )?;
         let p_bigint = limbs_to_bigint(params.bits_per_limb, &p_representations);
 
         let mut p_gadget_limbs = Vec::new();
@@ -474,8 +473,8 @@ impl<TargetF: PrimeField, BaseF: PrimeField> AllocatedEmulatedFpVar<TargetF, Bas
 
         // Get delta = self - other
         let cs = self.cs().or(other.cs()).or(should_enforce.cs());
-        let mut delta = self.sub_without_reduce(other)?;
-        delta = should_enforce.select(&delta, &Self::zero(cs.clone())?)?;
+        let delta = self.sub_without_reduce(other)?;
+        let delta = should_enforce.select(&delta, &Self::zero(cs.clone())?)?;
 
         // Allocate k = delta / p
         let k_gadget = FpVar::<BaseF>::new_witness(ns!(cs, "k"), || {

From ae57a7882b4917413cf55e51fc22b8ef1fc5861e Mon Sep 17 00:00:00 2001
From: Pratyush Mishra <pratyush795@gmail.com>
Date: Mon, 18 Mar 2024 22:21:43 -0700
Subject: [PATCH 3/3] Update src/fields/emulated_fp/allocated_field_var.rs

---
 src/fields/emulated_fp/allocated_field_var.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/fields/emulated_fp/allocated_field_var.rs b/src/fields/emulated_fp/allocated_field_var.rs
index a717ba07..e4721634 100644
--- a/src/fields/emulated_fp/allocated_field_var.rs
+++ b/src/fields/emulated_fp/allocated_field_var.rs
@@ -303,7 +303,7 @@ impl<TargetF: PrimeField, BaseF: PrimeField> AllocatedEmulatedFpVar<TargetF, Bas
     }
 
     /// Convert a `TargetF` element into limbs (not constraints).
-    /// This is an utility function intended
+    /// This is a utility function intended
     /// to be reused by a number of other functions.
     pub fn get_limbs_representations(
         elem: &TargetF,