Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client-sdk: should notify clients for receiving transactions #262

Open
bordalix opened this issue Aug 16, 2024 · 8 comments · May be fixed by #273
Open

client-sdk: should notify clients for receiving transactions #262

bordalix opened this issue Aug 16, 2024 · 8 comments · May be fixed by #273
Assignees

Comments

@bordalix
Copy link
Collaborator

No description provided.

@tiero
Copy link
Member

tiero commented Aug 16, 2024

or ideally the client-sdk can do polling client-side and offer subscriptions

@tiero tiero changed the title arkd should notify clients for receiving transactions client-sdk: should notify clients for receiving transactions Aug 20, 2024
@sekulicd
Copy link
Collaborator

Is bellow interface method ok? @tiero @bordalix
PaymentNotification(ctx context.Context, pubKey string) (<-chan Payment, error)

Check init solution in here

@bordalix
Copy link
Collaborator Author

@sekulicd maybe include a Status key to struct Payment?

@sekulicd
Copy link
Collaborator

@sekulicd maybe include a Status key to struct Payment?

Can you give me more context about status you are expecting?

@bordalix
Copy link
Collaborator Author

@sekulicd maybe include a Status key to struct Payment?

Can you give me more context about status you are expecting?

At least success or error

@sekulicd
Copy link
Collaborator

@sekulicd maybe include a Status key to struct Payment?

Can you give me more context about status you are expecting?

At least success or error

My understanding is that when round is finalised all offchain payments are successful, in round and payment domain i dont see any status field that could suggest that smtn failed.

@bordalix
Copy link
Collaborator Author

@sekulicd maybe include a Status key to struct Payment?

Can you give me more context about status you are expecting?

At least success or error

My understanding is that when round is finalised all offchain payments are successful, in round and payment domain i dont see any status field that could suggest that smtn failed.

What about claiming transactions?

@tiero
Copy link
Member

tiero commented Aug 21, 2024

@sekulicd We have introduced an offline payment scheme now in cl-ark (covenant-less ark) where basically you're credited a VTXO that is with a status “pending”
https://github.com/ark-network/ark/blob/master/api-spec/protobuf/ark/v1/service.proto#L247-L248

Look live example on MutinyNet
https://asp-signet.arklabs.to/v1/vtxos/tark1qwvvzgw0ayvuqyw7754nmgu26nd4a532y0tv2m3y6xyzfhvdrvqmwq3ht683yhmmku2798tseqddxdfdf6tpygyck7nffa5jw0x2xyfpeqc2utzt

@sekulicd sekulicd linked a pull request Aug 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants