Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support “port_channel” interface in “router_service_insertion” -> “connections” for Internet exit #4908

Open
1 task done
ashenoy-arista opened this issue Jan 21, 2025 · 1 comment
Labels
type: enhancement New feature or request

Comments

@ashenoy-arista
Copy link
Contributor

Enhancement summary

Need logic support in eos_cli_config_gen schema and jinja template to render “port_channel” interface in “router_service_insertion” -> “connections”

This will be useful to support Direct Internet exit configuration on cv-pathfinder wan routers using Port-Channel interface.

File: python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_service_insertion.schema.yml
For eos_cli_config_gen schema, need to add attribute “port_channel_interface” (of type dict) under “router_service_insertion” -> “connections”
(similar to “ethernet_interface”) containing keys - “name”, “next_hop”

Supporting changes needed to files in eos_cli_config_gen :
File: python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-service-insertion.j2
File: python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/router-service-insertion.j2

Which component of AVD is impacted

eos_cli_config_gen

Use case example

Use-case is to support Direct Internet exit configuration on cv-pathfinder wan routers using Port-Channel interface

Post this change , we need some minor work on eos_designs side to generate relevant structured config to facilitate eos_cli_config_gen generate EOS cli.
Specifically
File: python-avd/pyavd/_eos_designs/structured_config/network_services/router_service_insertion.py
Property : router_service_insertion
to add service_connection[“port_channel_interface”] for connection type "port_channel"

Describe the solution you would like

Extend eos_cli_config_gen schema to allow rendering of “port_channel” interface in “router_service_insertion” -> “connections” to generate related EOS cli.
Some additional changes needed on eos_designs side as well

Describe alternatives you have considered

No response

Additional context

No response

Contributing Guide

  • I agree to follow this project's Code of Conduct
@ClausHolbechArista
Copy link
Contributor

Since this is still not supported on EOS, we will keep this request on hold for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants