Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support microsecond unit for qos_profiles thresholds #4900

Open
1 task done
aeshap opened this issue Jan 21, 2025 · 0 comments
Open
1 task done

Support microsecond unit for qos_profiles thresholds #4900

aeshap opened this issue Jan 21, 2025 · 0 comments
Labels
type: enhancement New feature or request

Comments

@aeshap
Copy link

aeshap commented Jan 21, 2025

Enhancement summary

Support microsecond unit for qos_profiles:tx_queues:random_detect_:ecn:thresholds:units. This is required for AI designs

AVD currently only support below:
threshold:

          # Units to be used for the threshold values.
          # This should be one of segments, byte, kbytes, mbytes.
          units: <str; "segments" | "bytes" | "kbytes" | "mbytes" | "milliseconds"; required>

On DCS-7280SRA-48C6 running 4.30.3M (Jericho)
PS-VAN1-Spine-2(config-qos-profile-RDMA-QOS-PROFILE-txq-3)#random-detect ecn minimum-threshold 10 ?
bytes Set threshold in bytes
kbytes Set threshold in kbytes
mbytes Set threshold in mbytes
microseconds Set threshold in microseconds
milliseconds Set threshold in milliseconds

Which component of AVD is impacted

eos_cli_config_gen

Use case example

AI fabrics requires qos profiles with micro-second thresholds. Config from AI fabric customer

qos profile RDMA-QOS-PROFILE
priority-flow-control on
priority-flow-control priority 3 no-drop
!
tx-queue 3
no priority
bandwidth percent 100
random-detect ecn minimum-threshold 320 microseconds maximum-threshold 480 microseconds max-mark-probability 100
random-detect ecn count
!
tx-queue 6
no priority
!

Describe the solution you would like

Sample:
qos_profiles:

  • name: RDMA-QOS-PROFILE
    tx_queues:
    • id: 3
      bandwidth_percent: 100
      priority: "no priority"
      random_detect:
      ecn:
      count: true
      threshold:
      units: "microseconds"
      min: 320
      max: 480
      max_probability: 100

Describe alternatives you have considered

none explored yet

Additional context

No response

Contributing Guide

  • I agree to follow this project's Code of Conduct
@aeshap aeshap added the type: enhancement New feature or request label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant