Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat (eos_cli_config_gen): Add ICMP echo size for Monitor Connectivity hosts #4848

Open
1 task done
ctyrider opened this issue Jan 2, 2025 · 6 comments · May be fixed by #4853
Open
1 task done

Feat (eos_cli_config_gen): Add ICMP echo size for Monitor Connectivity hosts #4848

ctyrider opened this issue Jan 2, 2025 · 6 comments · May be fixed by #4853
Assignees
Labels
type: enhancement New feature or request

Comments

@ctyrider
Copy link

ctyrider commented Jan 2, 2025

Enhancement summary

Add support for "icmp echo size ..." CLI syntax, under Monitor Connectivity hosts:

monitor connectivity
   host <HOST-NAME>
      icmp echo size <36-18024>
   vrf <VRF-NAME>
      host <HOST-NAME>
         icmp echo size <36-18024>

Which component of AVD is impacted

eos_cli_config_gen

Use case example

Specify custom size of ICMP echo probes for Monitor Connectivity Hosts

Describe the solution you would like

New icmp_echo_size variable in eos_cli_config_gen:

monitor_connectivity:
  hosts:
     - name: <str; required; unique>
       icmp_echo_size: <int>
  vrfs:
     - name: <str; required; unique>
	   hosts:
             - name: <str; required; unique>
               icmp_echo_size: <int>

Describe alternatives you have considered

n/a

Additional context

n/a

Contributing Guide

  • I agree to follow this project's Code of Conduct
@ctyrider ctyrider added the type: enhancement New feature or request label Jan 2, 2025
@gmuloc
Copy link
Contributor

gmuloc commented Jan 3, 2025

Hi @ctyrider - thanks for opening this issue. Do you wish to take a stab at the PR?

@ctyrider
Copy link
Author

ctyrider commented Jan 3, 2025

Hi @ctyrider - thanks for opening this issue. Do you wish to take a stab at the PR?

I've raised a PR #4853 This is my first time raising a PR for AVD, and I am having a small issue locally running Molecule in venv environment - getting an exception "The error was: importlib.metadata.PackageNotFoundError: No package metadata was found for pyavd" when running Molecule:

Perhaps you could give me a pointer as to what's causing the issue and how to resolve? I've installed local Python packages, as instructed by "Development Tooling" article: pip3 install -r ansible_collections/arista/avd/requirements-dev.txt --upgrade

Exact error is below:

(avd-venv) ➜  avd git:(issue4848) molecule converge -s eos_cli_config_gen
INFO     eos_cli_config_gen scenario test matrix: syntax, converge
INFO     Performing prerun with role_name_check=0...
INFO     Running eos_cli_config_gen > syntax

playbook: /root/git_projects/avd/ansible_collections/arista/avd/molecule/eos_cli_config_gen/converge.yml
INFO     Running eos_cli_config_gen > converge

PLAY [Converge] ****************************************************************

TASK [arista.avd.eos_cli_config_gen : Verify Requirements] *********************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: importlib.metadata.PackageNotFoundError: No package metadata was found for pyavd
fatal: [host_inline_jinja -> localhost]: FAILED! => {"msg": "Unexpected failure during module execution: No package metadata was found for pyavd", "stdout": ""}

@gmuloc
Copy link
Contributor

gmuloc commented Jan 7, 2025

Hi apologies for answering this late

So this is an unforeseen change of one of my recent improvements it seems (will tackle this)
here is what you need to do:

# From the root of the folder
cd python-avd
make pyavd-build

It will create the necessary metadata for Verify Requirements to work

@ctyrider
Copy link
Author

ctyrider commented Jan 7, 2025

Hi apologies for answering this late

So this is an unforeseen change of one of my recent improvements it seems (will tackle this) here is what you need to do:

# From the root of the folder
cd python-avd
make pyavd-build

It will create the necessary metadata for Verify Requirements to work

I worked around this by installing pyavd 4.10.2 locally:

(avd-venv) ➜  avd git:(issue4848) pip3 list | grep pyavd
pyavd                     4.10.2

Molecule runs now.

@ctyrider
Copy link
Author

ctyrider commented Jan 7, 2025

@gmuloc
#4853 ready to merge - please review

@gmuloc
Copy link
Contributor

gmuloc commented Jan 7, 2025

Hi apologies for answering this late
So this is an unforeseen change of one of my recent improvements it seems (will tackle this) here is what you need to do:

# From the root of the folder
cd python-avd
make pyavd-build

It will create the necessary metadata for Verify Requirements to work

I worked around this by installing pyavd 4.10.2 locally:

(avd-venv) ➜  avd git:(issue4848) pip3 list | grep pyavd
pyavd                     4.10.2

Molecule runs now.

yeah the piece of code just need to be able to run any metadata but it should gracefully ignore it it can't find any.
molecule should not use this pyavd version you have installed as it would be running from source but I would recommend installing pyavd 5.1.0 still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants