-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat (eos_cli_config_gen): Add ICMP echo size for Monitor Connectivity hosts #4848
Comments
Hi @ctyrider - thanks for opening this issue. Do you wish to take a stab at the PR? |
I've raised a PR #4853 This is my first time raising a PR for AVD, and I am having a small issue locally running Molecule in venv environment - getting an exception "The error was: importlib.metadata.PackageNotFoundError: No package metadata was found for pyavd" when running Molecule: Perhaps you could give me a pointer as to what's causing the issue and how to resolve? I've installed local Python packages, as instructed by "Development Tooling" article: Exact error is below:
|
Hi apologies for answering this late So this is an unforeseen change of one of my recent improvements it seems (will tackle this)
It will create the necessary metadata for Verify Requirements to work |
I worked around this by installing pyavd 4.10.2 locally:
Molecule runs now. |
yeah the piece of code just need to be able to run any metadata but it should gracefully ignore it it can't find any. |
Enhancement summary
Add support for "icmp echo size ..." CLI syntax, under Monitor Connectivity hosts:
Which component of AVD is impacted
eos_cli_config_gen
Use case example
Specify custom size of ICMP echo probes for Monitor Connectivity Hosts
Describe the solution you would like
New
icmp_echo_size
variable ineos_cli_config_gen
:Describe alternatives you have considered
n/a
Additional context
n/a
Contributing Guide
The text was updated successfully, but these errors were encountered: