Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback first code #1

Open
4 tasks
mstoelzle opened this issue Jul 15, 2020 · 0 comments
Open
4 tasks

Feedback first code #1

mstoelzle opened this issue Jul 15, 2020 · 0 comments
Assignees
Labels

Comments

@mstoelzle
Copy link
Contributor

Some feedback for the Fall_only_model.py:

  • You need to include a plt.show() or plt.save() at the end to actually show the plot
  • You need to put the main code, which initiates all the action, into the __main__ condition, to execute it when you run it as a script from the command line (https://docs.python.org/3/library/__main__.html)
  • Add some code comments, what those parameters you specify actually physically mean
  • You would call the timestep not t but rather dt. For the start, its sufficient to use a constant step size to integrate the physical system. Later, if you would introduce more nonlinear dynamics, you might want to use this solver for your system: https://docs.scipy.org/doc/scipy/reference/generated/scipy.integrate.solve_ivp.html

I think its a good start and I am excited to see where you will take the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants