Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipv4 and ipv6 accept CIDR #116

Open
anewton1998 opened this issue Jan 18, 2018 · 5 comments
Open

ipv4 and ipv6 accept CIDR #116

anewton1998 opened this issue Jan 18, 2018 · 5 comments
Labels

Comments

@anewton1998
Copy link
Contributor

Strictly speaking, they shouldn't.

@anewton1998
Copy link
Contributor Author

or we add these as explicit types

@codalogic
Copy link
Contributor

Some sort of IP address range seems appropriate. And seems reasonable that it should be a distinct type from a single address.

@codalogic
Copy link
Contributor

Thinking out loud, echoing what we've done for ranges elsewhere, the following might be suitable names for IP address range: ipv4.., ipv6.., ipaddr...

@anewton1998
Copy link
Contributor Author

I think most people would think of them as CIDR. ipv4.. is a range of what? I think we just need cidrv4, cidrv6 and cidr. The only thing that might make sense is cidrv4..24 where we are saying it must be a /24 of ipv4. But the vast majority of the time I see this type of stuff it's "I want 24 or greater" or "I want less than 24", which cidrv4..24 doesn't express.

@codalogic
Copy link
Contributor

That all makes sense to me. I agree cidrv4 does seem more explicit than ipv4..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants