Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radians and Degrees #4

Open
SterlingPeet opened this issue Mar 12, 2015 · 1 comment
Open

Radians and Degrees #4

SterlingPeet opened this issue Mar 12, 2015 · 1 comment

Comments

@SterlingPeet
Copy link
Contributor

Angles are sometimes expressed as Radians, but the Simulator initial conditions and a few other locations are in Degrees. Choosing one convention (I recommend radians) for the whole simulator and sticking to it is less confusing.

@arindam1993
Copy link
Owner

Fair point,my idea was to implement something similar to what most Game Engines/3D Software Packages(Unity, Blender) will implement, anything user facing will allow you to set up in degrees and convert internally to a Quaternion or a Transform Matrix, I took the approach of using rotation matrices internally. I don't really understand Quaternions properly enough to implement them.
I'll consult with Prof. Tucker and refactor accordingly, thanks for pointing this out though, I understand it can be confusing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants