We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi,
while playing around with rendering to *output-stream* versus rendering to a string, I got the following:
*output-stream*
CL-USER> (use-package :cl-markup) T CL-USER> (markup (:ul (loop for item in '(1 2 3) collect (markup (:li item))))) "<ul><li>1</li><li>2</li><li>3</li></ul>" CL-USER> (let ((*output-stream* t)) (markup (:ul (loop for item in '(1 2 3) collect (markup (:li item)))))) <ul><li>1</li><li>2</li><li>3</li></li></li></li></ul> "</ul>" CL-USER>
Note the additional and unexpected closing tags </li> in the second output.
</li>
Is this invalid client code or a bug?
If it is a bug, perhaps the expansion under the (IF *OUTPUT-STREAM* regime should generate a PROGN that contains NIL as its last form.
(IF *OUTPUT-STREAM*
PROGN
NIL
In the above example, the last form of the PROGN is (WRITE-STRING "</li>" *OUTPUT-STREAM*).
(WRITE-STRING "</li>" *OUTPUT-STREAM*)
The text was updated successfully, but these errors were encountered:
That fixes it for me https://github.com/kisp/cl-markup/commit/703a6a4087ee4de948b83f61874024de29e2a004
Should I open a pull request?
Sorry, something went wrong.
No branches or pull requests
Hi,
while playing around with rendering to
*output-stream*
versus rendering to a string, I got the following:Note the additional and unexpected closing tags
</li>
in the second output.Is this invalid client code or a bug?
If it is a bug, perhaps the expansion under the
(IF *OUTPUT-STREAM*
regime should generate aPROGN
that containsNIL
as its last form.In the above example, the last form of the
PROGN
is(WRITE-STRING "</li>" *OUTPUT-STREAM*)
.The text was updated successfully, but these errors were encountered: