Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Client: Sound Manager Issues #742

Open
2 of 4 tasks
AntumDeluge opened this issue Jun 20, 2024 · 0 comments
Open
2 of 4 tasks

Web Client: Sound Manager Issues #742

AntumDeluge opened this issue Jun 20, 2024 · 0 comments
Assignees
@AntumDeluge
Labels
component: webclient Related to the web client. type: bug Causes a negative impact or not working as intended.
Milestone
1.48

Comments

@AntumDeluge
Copy link
Member

AntumDeluge commented Jun 20, 2024 •
edited
Loading

🐞 Describe the bug

  • Sound Manager: Value being assigned is not a finite floating-point value #714
  • gaps between music/looped sounds (this could be browser dependent)
  • volume levels may not be set correctly from settings dialog (2df0596)
    • HTMLAudioElement uses floating point value between 0.0-1.0. Stendhal uses integer value between 0-100. The issue is likely due to values not being translated correctly.
  • Performance is affected by a substantial number of sound events on large maps with many creatures. To mitigate the problem, entities that are too far away to be heard should be ignored. (87c1111)

🌍 Environment

  • Web client
@AntumDeluge AntumDeluge added type: bug Causes a negative impact or not working as intended. component: webclient Related to the web client. labels Jun 20, 2024
@AntumDeluge AntumDeluge added this to the 1.48 milestone Jun 20, 2024
@AntumDeluge AntumDeluge self-assigned this Jun 20, 2024
AntumDeluge added a commit that referenced this issue Jul 15, 2024
@AntumDeluge
Don't load sounds for events that are too far to be heard
87c1111 
#742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AntumDeluge AntumDeluge

Labels
component: webclient Related to the web client. type: bug Causes a negative impact or not working as intended.
Projects
None yet
Milestone
1.48
Development

No branches or pull requests
1 participant
@AntumDeluge