Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional bit of precision lost with curve change #1124

Open
cpacia opened this issue Feb 13, 2024 · 1 comment
Open

Additional bit of precision lost with curve change #1124

cpacia opened this issue Feb 13, 2024 · 1 comment

Comments

@cpacia
Copy link
Contributor

cpacia commented Feb 13, 2024

With the change in curves the pack_bits gadget is now dropping the first three bits instead of just the first two as was the case with the prior curves.

This affects the sha256 coprocessor. It's just a one liner change, I can submit a PR if you want but I don't know if there are other areas of lurk that might be affected by this.

@arthurpaulino
Copy link
Member

Sure, you can go for the minimal PR and then we evaluate the need of subsequent PRs afterwards.

Thanks for opening the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants