Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial screenshot upload #1189

Open
oliviertassinari opened this issue Feb 6, 2024 · 3 comments
Open

Partial screenshot upload #1189

oliviertassinari opened this issue Feb 6, 2024 · 3 comments
Labels

Comments

@oliviertassinari
Copy link
Contributor

oliviertassinari commented Feb 6, 2024

As a user, I would like to be able to only upload a sub-set of my screenshots, based on the files that I know changed relative to the baseline.

Motivation

At MUI, we take screenshots of React components. We should be able to create a webpack plugin that skip the emission of all the modules that didn't change in the git diff and that have not parent dependency. This would allow us to take/diff 10 screenshots per build rather than 1,000. So a gain of two orders of magnitude.

Benchmarks

@gregberge
Copy link
Member

Hello @oliviertassinari, it's very interesting. It could dramatically speed up the build time for you! I will think about it and I keep you up to date.

@oliviertassinari
Copy link
Contributor Author

oliviertassinari commented Feb 7, 2024

To be fair, we don't have the bandwidth to update our screenshot generator to support this. However, I know Argos has one for different tools so I thought that I would open an issue. It could be a way for Argos to differentiate, I don't know if Chromatic does this for instance.

The way to solve pricing is either to bill skipped screenshots or to add a per editor component.

@gregberge
Copy link
Member

Chromatic does it yes but they have the control over Storybook so it's integrated. https://www.chromatic.com/docs/turbosnap/

For Argos we can't make it automatic that's why it's not a urgent issue. For enterprise projects with lot of screenshots I think it's interesting.

@gregberge gregberge added the feat label Mar 13, 2024
@gregberge gregberge moved this to 🔖 Ready in Argos Roadmap Mar 13, 2024
@gregberge gregberge moved this from 🔖 Ready to 📋 Backlog in Argos Roadmap Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants