Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add timeout to apply/replace kubectl calls (#572) #573

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add timeout to apply/replace kubectl calls (#572) #573

wants to merge 1 commit into from

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented May 4, 2024 •
edited
Loading

See parent issue for details.

This PR:

  • Sets a 1 hour timeout for an Apply request to complete.
    • (I'm definitely open to other values here, but my expectation is users would only expect an apply to be active for seconds, or at most a single digit number of minutes).
    • For contrast, the timeout for replace (when force=true) is 5 minutes

Why no timeout for create operation? Not supported by kubectl code, AFAICT. Why no timeout for replace? Not supported by kubectl code, except in the case where force is true, in which case the timeout is 5 minutes.

Fixes #572

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jgwest jgwest marked this pull request as ready for review May 6, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@jgwest