feat: sync with apps-of-apps (#32) #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
crenshaw-dev
requested changes
Mar 8, 2024
argoproj/base/argo-cd.yaml
Outdated
Comment on lines
6
to
8
| ### Just as a prevention, we do not want ArgoCD to self delete | ||
| # finalizers: | ||
| # - resources-finalizer.argocd.argoproj.io |
There was a problem hiding this comment.
Meant to still be commented out?
There was a problem hiding this comment.
I though that leaving the config commented out with the explanation on top was I good idea, this way people that look at the apps aren't asking themselves why is there no finalizer to this app or why isn't the sync enabled? was it on purpose or someone forgot?
Since it is a demo setup, I think it is interesting to explicitly explain why it is commented.
ditto for all commented sections in Apps.
What do you think?
Signed-off-by: Alexandre Gaudreault <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32
Note: The 2 new apps are already applied in the cluster