Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart argo-cd: ingress annotation template error #3114

Open
rverchere opened this issue Jan 9, 2025 · 1 comment
Open

Chart argo-cd: ingress annotation template error #3114

rverchere opened this issue Jan 9, 2025 · 1 comment
Labels
argo-cd bug Something isn't working

Comments

@rverchere
Copy link

Describe the bug

When trying to update to argo-cd chart version 7.7.14, I get the following error:

Error: Failed to render chart: exit status 1: Error: template: argo-cd/templates/argocd-server/ingress.yaml:17:23: executing "argo-cd/templates/argocd-server/ingress.yaml" at <$value>: wrong type for value; expected string; got bool

It is related to the PR #3081 which enable ingress templating.

My custom values are:

server:
  ingress:
    annotations:
      nginx.ingress.kubernetes.io/ssl-passthrough: true

Modifying the annotations by converting from bool to string corrects the issue:

server:
  ingress:
    annotations:
      nginx.ingress.kubernetes.io/ssl-passthrough: "true"

Related helm chart

argo-cd

Helm chart version

7.7.14

To Reproduce

  1. Add a custom value in server.ingress.annotations with a boolean value
  2. Try to install/update

Expected behavior

Annotation should be set as previously, maybe by converting bool to string.

Screenshots

No response

Additional context

No response

@rverchere rverchere added the bug Something isn't working label Jan 9, 2025
@tmsdce
Copy link

tmsdce commented Jan 9, 2025

Hi @rverchere

According to the notes in Kubernetes documentation, annotations must strictly be strings. In that regard, the chart behavior seems correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-cd bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants