Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] [SDK] Improve logging when adding and updating records #4947

Closed
burtenshaw opened this issue Jun 3, 2024 · 2 comments · Fixed by #4869
Closed

[FEATURE] [SDK] Improve logging when adding and updating records #4947

burtenshaw opened this issue Jun 3, 2024 · 2 comments · Fixed by #4869
Assignees
@frascuchon @burtenshaw
Labels
area: python sdk Indicates that an issue or pull request is related to the Python SDK
Milestone
v2.0.0

Comments

@burtenshaw
Copy link
Contributor

When adding records from a notebook the logging is very minimal:

image

It would make sense to

  • show a status bar
  • log the number of records that were added or updated
  • log a link to the dataset
  • be notebook compatible.
  • consider returning theDatasetRecords object instead of the records themselves.
@frascuchon
Copy link
Member

frascuchon commented Jun 4, 2024 •
edited
Loading

cc @burtenshaw do you think this can be relevant for v2?

@burtenshaw
Copy link
Contributor Author

burtenshaw commented Jun 5, 2024 •
edited
Loading

@frascuchon @nataliaElv Yes. I'd like to work on this asap. Move it to 2.0.

@burtenshaw burtenshaw transferred this issue from argilla-io/argilla-python Jun 5, 2024
@burtenshaw burtenshaw added this to the v2.0.0 milestone Jun 5, 2024
@burtenshaw burtenshaw changed the title [FEATURE] Improve logging when adding and updating records [FEATURE] [SDK] Improve logging when adding and updating records Jun 5, 2024
@burtenshaw burtenshaw added the area: python sdk Indicates that an issue or pull request is related to the Python SDK label Jun 5, 2024
@burtenshaw burtenshaw linked a pull request Jun 10, 2024 that will close this issue
[FEATURE-BRANCH] v2.0.0 changes #4869
Merged
31 tasks
@frascuchon frascuchon mentioned this issue Jun 12, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frascuchon frascuchon

@burtenshaw burtenshaw

Labels
area: python sdk Indicates that an issue or pull request is related to the Python SDK
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

[FEATURE-BRANCH] v2.0.0 changes argilla-io/argilla
2 participants
@frascuchon @burtenshaw