Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

[TASK] Migrate DELETE /api/users/:user_id endpoint to DELETE /api/v1/users/:user_id #147

Closed
Tracked by #4773
jfcalvo opened this issue May 7, 2024 · 0 comments · Fixed by #148
Closed
Tracked by #4773
Assignees

Comments

@jfcalvo
Copy link
Member

jfcalvo commented May 7, 2024

No description provided.

@jfcalvo jfcalvo self-assigned this May 7, 2024
@jfcalvo jfcalvo transferred this issue from argilla-io/argilla May 7, 2024
@jfcalvo jfcalvo changed the title [TASK] Migrate DELETE /users/:user_id endpoint to DELETE /api/v1/users/:user_id [TASK] Migrate DELETE /api/users/:user_id endpoint to DELETE /api/v1/users/:user_id May 7, 2024
jfcalvo added a commit that referenced this issue May 13, 2024
…1/users/:user_id` (#148)

# Description

This PR migrate adds a new endpoint `DELETE /api/v1/users/:user_id`
allowing the deletion of users using API v1.

Closes #147 

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (change restructuring the codebase without changing
functionality)
- [ ] Improvement (change adding some improvement to an existing
functionality)
- [ ] Documentation update

**How Has This Been Tested**

- [x] Adding new tests and checking that old tests for API v0 pass with
API v1 implementation.

**Checklist**

- [ ] I added relevant documentation
- [ ] follows the style guidelines of this project
- [ ] I did a self-review of my code
- [ ] I made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK)
(see text above)
- [ ] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
@jfcalvo jfcalvo closed this as completed May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant