Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component breaking because of moment version #199

Open
gdelacruzfdez opened this issue May 4, 2020 · 1 comment
Open

Component breaking because of moment version #199

gdelacruzfdez opened this issue May 4, 2020 · 1 comment

Comments

@gdelacruzfdez
Copy link

gdelacruzfdez commented May 4, 2020

Bug
The new version of moment library breaks the component and the build. Other people have the same issue.

It is very simple to fix, we just need to fix the moment version to ~2.24.0.

WARNING in ./node_modules/semantic-ui-calendar-react/node_modules/moment/src/lib/locale/locales.js
Module not found: Error: Can't resolve './locale' in '/home/gdelacruz/CERN/remus-web/frontend/node_modules/semantic-ui-calendar-react/node_modules/moment/src/lib/locale'
 @ ./node_modules/semantic-ui-calendar-react/node_modules/moment/src/lib/locale/locales.js
 @ ./node_modules/semantic-ui-calendar-react/node_modules/moment/src/lib/locale/locale.js
 @ ./node_modules/semantic-ui-calendar-react/node_modules/moment/src/moment.js
 @ ./node_modules/semantic-ui-calendar-react/dist/commonjs/inputs/YearInput.js
 @ ./node_modules/semantic-ui-calendar-react/dist/commonjs/index.js
 @ ./src/components/MeteoDataExtraction/MeteoDataExtractionForm/index.jsx
 @ ./src/pages/MeteoDataExtractionPage/index.jsx
 @ ./src/pages/index.js
 @ ./src/nav/ContentContainer/index.jsx
 @ ./src/nav/index.jsx
 @ ./src/App.jsx
 @ ./src/index.jsx
 @ multi ./node_modules/error-overlay-webpack-plugin/lib/entry-basic.js ./node_modules/error-overlay-webpack-plugin/lib/entry-devserver.js? ./src/index.jsx

To Reproduce
Just reinstalling node_modules and running your app it should break.

Pull request #200 fixes the issue

@gdelacruzfdez
Copy link
Author

gdelacruzfdez commented May 4, 2020

The issue has been fixed in moment library. Anyway, it may be a good idea to fix the version of moment to avoid that the same issue happens again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant