New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BDData `show` throws error when data is list #28

Open

pkimes opened this issue Feb 2, 2019 · 0 comments

Assignees

Collaborator

pkimes commented Feb 2, 2019

Following error thrown when just trying to print BDData object.

> bd@data
BenchDesign Data (BDData) ----------------------------------
  type: data
  data summary:
Error: All columns in a tibble must be 1d or 2d objects:
* Column `names` is NULL
Call `rlang::last_error()` to see a backtrace

Need to fix one line to not call sapply - just need to call names directly.
https://github.com/areyesq89/SummarizedBenchmark/blob/RELEASE_3_8/R/BDData-show.R#L17

Also need to fix how dimensions/length is calculated for show of list entires.

The text was updated successfully, but these errors were encountered:

pkimes self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment