New sensor, what files to provide in the pull request? #18737
Vincent1964
started this conversation in
General
Replies: 2 comments
-
The PR should include the changes in Bug found in existing code is always an extra standalone PR. |
Beta Was this translation helpful? Give feedback.
0 replies
-
I'll fix Xsns1019 now. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi,
I am developing a new sensor driver for the MAX17043 battery power gauge. Should my pull request contain also "my_user_config.h" and the "i18n.h" includes?
I also found an error in tasmota/tasmota_xx2c_global/xsns_interface.ino (line 459, &Xsns109 is missing a comma). I propose I add this to my pull request.
Kind regards,
Vincent
Beta Was this translation helpful? Give feedback.
All reactions