Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow HandleTranslations to be imported in any order #2712

Open
antonioribeiro opened this issue Dec 25, 2024 · 0 comments
Open

Allow HandleTranslations to be imported in any order #2712

antonioribeiro opened this issue Dec 25, 2024 · 0 comments

Comments

@antonioribeiro
Copy link
Member

Summary

This line of code forces us to use HandleTranslations; in a order that doesn't affects the translations keys, because, if you load it after some other trait that adds things to the translations array it will be cleared and coming to the form lost.

Describe the solution you'd like

Ideally this unset() should go away. Is there a better way to ensure there will be no "strange" keys to HandleTranslations here?

Additional context

Found this because I had use HandleMetadata (which adds a lot of stuff to the translations array) loaded before it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant