Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Libraries for Modbus TCP Communication #5894

Merged
merged 1 commit into from
Feb 9, 2025
Merged

Conversation

CMB27
Copy link
Contributor

@CMB27 CMB27 commented Feb 9, 2025

This adds two libraries.

  • ModbusTCPComm, is for sending and receiving Modbus data frames over TCP.
  • ModbusTCPSlave, depends on the first and implements Modbus slave/server processing for this communication.

@github-actions github-actions bot added the topic: submission Add library to the list label Feb 9, 2025
Copy link
Contributor

github-actions bot commented Feb 9, 2025

A problem was found with your submission https://github.com/CMB27/ModbusTCPSlave

ERROR: Unable to load submission URL. Is the repository public?

Copy link
Contributor

github-actions bot commented Feb 9, 2025

Arduino Lint has suggestions for possible improvements to https://github.com/CMB27/ModbusTCPComm:

Linting library in ModbusTCPComm
WARNING: library.properties includes field item(s) ModbusADU.h not found in library.                           
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP052)                                                                                          
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Copy link
Contributor

github-actions bot commented Feb 9, 2025

Thanks for your interest in contributing to the Arduino Library Manager index @CMB27
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@CMB27
Copy link
Contributor Author

CMB27 commented Feb 9, 2025

ModbusTCPSlave was not a public repository when I first submitted this pull request. It has now been changed to a public repository.

@ArduinoBot do your thing.

Copy link
Contributor

github-actions bot commented Feb 9, 2025

Hello! I'm checking your submission again.

Copy link
Contributor

github-actions bot commented Feb 9, 2025

Arduino Lint has suggestions for possible improvements to https://github.com/CMB27/ModbusTCPSlave:

Linting library in ModbusTCPSlave
WARNING: library.properties depends field item(s) ModbusTCPComm (>=0.0.1) not found in the Library Manager index.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format  
         (Rule LP048)                                                                                            

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in ModbusTCPSlave/examples/ModbusTCPSlaveEthernetExample

Linter results for project: no errors or warnings

-------------------

Linting sketch in ModbusTCPSlave/examples/ModbusTCPSlaveWiFiExample

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

Copy link
Contributor

github-actions bot commented Feb 9, 2025

Arduino Lint has suggestions for possible improvements to https://github.com/CMB27/ModbusTCPComm:

Linting library in ModbusTCPComm
WARNING: library.properties includes field item(s) ModbusADU.h not found in library.                           
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP052)                                                                                          
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

@github-actions github-actions bot merged commit 6dda5df into arduino:main Feb 9, 2025
15 checks passed
Copy link
Contributor

github-actions bot commented Feb 9, 2025

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/CMB27/ModbusTCPComm/
http://downloads.arduino.cc/libraries/logs/github.com/CMB27/ModbusTCPSlave/

github-actions bot pushed a commit that referenced this pull request Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant