Skip to content

Commit ac60f9c

Browse files
Added missing virtual destructors
1 parent 65633ce commit ac60f9c

File tree

8 files changed

+9
-1
lines changed

8 files changed

+9
-1
lines changed

Diff for: api/Client.h

+1
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ namespace arduino {
2727
class Client : public Stream {
2828

2929
public:
30+
virtual ~Client() {};
3031
virtual int connect(IPAddress ip, uint16_t port) =0;
3132
virtual int connect(const char *host, uint16_t port) =0;
3233
virtual size_t write(uint8_t) =0;

Diff for: api/HardwareI2C.h

+1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ namespace arduino {
2626
class HardwareI2C : public Stream
2727
{
2828
public:
29+
virtual ~HardwareI2C() {}
2930
virtual void begin() = 0;
3031
virtual void begin(uint8_t address) = 0;
3132
virtual void end() = 0;

Diff for: api/HardwareSerial.h

+1
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ namespace arduino {
8787
class HardwareSerial : public Stream
8888
{
8989
public:
90+
virtual ~HardwareSerial() {}
9091
virtual void begin(unsigned long) = 0;
9192
virtual void begin(unsigned long baudrate, uint16_t config) = 0;
9293
virtual void end() = 0;

Diff for: api/Printable.h

+1
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ class Print;
3333
class Printable
3434
{
3535
public:
36+
virtual ~Printable() {}
3637
virtual size_t printTo(Print& p) const = 0;
3738
};
3839

Diff for: api/Server.h

+1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ namespace arduino {
2525

2626
class Server : public Print {
2727
public:
28+
virtual ~Server() {}
2829
virtual void begin() = 0;
2930
};
3031

Diff for: api/Stream.h

+1
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ class Stream : public Print
6262
virtual int peek() = 0;
6363

6464
Stream() {_timeout=1000;}
65+
virtual ~Stream() {}
6566

6667
// parsing methods
6768

Diff for: api/String.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ class String
8181
explicit String(unsigned long, unsigned char base=10);
8282
explicit String(float, unsigned char decimalPlaces=2);
8383
explicit String(double, unsigned char decimalPlaces=2);
84-
~String(void);
84+
virtual ~String(void);
8585

8686
// memory management
8787
// return true on success, false on failure (in which case, the string

Diff for: api/Udp.h

+2
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ namespace arduino {
4242
class UDP : public Stream {
4343

4444
public:
45+
virtual ~UDP() {}
46+
4547
virtual uint8_t begin(uint16_t) =0; // initialize, start listening on specified port. Returns 1 if successful, 0 if there are no sockets available to use
4648
virtual uint8_t beginMulticast(IPAddress, uint16_t) { return 0; } // initialize, start listening on specified multicast IP address and port. Returns 1 if successful, 0 on failure
4749
virtual void stop() =0; // Finish with the UDP socket

0 commit comments

Comments
 (0)