Merge pull request #193 from tttapa/patch-2

Fix stack buffer overflow in String::getBytes() test
arduino · Aug 1, 2023 · 84b98c7 · 84b98c7
2 parents 5b9faf6 + 363c2c4
commit 84b98c7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
@@ -121,8 +121,8 @@ add_compile_definitions(HOST)
 add_compile_options(-Wall -Wextra -Wpedantic -Werror)
 add_compile_options(-Wno-cast-function-type)
 
-set(CMAKE_C_FLAGS   ${CMAKE_C_FLAGS}   "--coverage")
-set(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} "--coverage -Wno-deprecated-copy")
+set(CMAKE_C_FLAGS   "${CMAKE_C_FLAGS} --coverage")
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --coverage -Wno-deprecated-copy")
 
 ##########################################################################
 

diff --git a/test/src/String/test_characterAccessFunc.cpp b/test/src/String/test_characterAccessFunc.cpp
@@ -45,10 +45,11 @@ TEST_CASE ("Testing String::getBytes(unsigned char, unsigned int, unsigned int)"
 
   WHEN("Valid operation") {
     arduino::String str("Hello");
-    unsigned char buf[2];
+    unsigned char buf[3];
     str.getBytes(buf, 5, 3);
     REQUIRE(buf[0] == 'l');
     REQUIRE(buf[1] == 'o');
+    REQUIRE(buf[2] == '\0');
   }
 }