Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delay(10) to wait for NTP data messes interrupt routines #112

Open
gibo77 opened this issue Jul 26, 2020 · 2 comments · May be fixed by #163 or #90
Open

delay(10) to wait for NTP data messes interrupt routines #112

gibo77 opened this issue Jul 26, 2020 · 2 comments · May be fixed by #163 or #90

Comments

@gibo77
Copy link

gibo77 commented Jul 26, 2020

Hi,
Can you change the program that has delay (10) in waiting for NTP data and use millis() instead. So that our interrupt in the main program will not be delayed.
Thanks!

  do {
    delay ( 10 );
    cb = this->_udp->parsePacket();
    if (timeout > 100) return false; // timeout after 1000 ms
    timeout++;
  }
@DaleSchultz
Copy link

I agree, this is a good suggestion.

@mlesniew mlesniew linked a pull request Jan 28, 2022 that will close this issue
Open
@mlesniew
Copy link

Hi guys, I've prepared a fix for this in PR #163

This was linked to pull requests Jan 28, 2022
Avoid blocking in NTPClient::update() #163
Open
Re-works the update() method to avoid blocking #90
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@mlesniew @gibo77 @DaleSchultz and others