Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard-coded check for action$ tag #1

Open
anton164 opened this issue Apr 3, 2020 · 0 comments
Open

Remove hard-coded check for action$ tag #1

anton164 opened this issue Apr 3, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@anton164
Copy link
Contributor

anton164 commented Apr 3, 2020

Currently the extension splits streams into two types base on their tag: :

title: 'Type',
valueRender: (emission => emission.tag === 'action$' ? `Action` : `Tagged stream`)
}, {
title: 'Value',
valueRender: (emission => emission.tag === 'action$' ? emission.value.type : emission.tag)

This split makes sense when using rxbeach, but this split should ideally be handled differently.

Perhaps we should introduce a setting + simple plugin architecture that controls this.

@anton164 anton164 added the enhancement New feature or request label Apr 3, 2020
@anton164 anton164 changed the title Remove hard-coded check for action$ tag Remove hard-coded check for action$ tag Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant