Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(descriptions): corrects the layout distribution issue of span #3409

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

oljc
Copy link
Member

@oljc oljc commented Jan 6, 2025

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Component style change
  • Typescript definition change
  • Documentation change
  • Coding style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Breaking change
  • Others

Background and context

span 计算规则不遵循用户配置的 span 导致无法判断 descriptions 预期表现,且偶尔不符合表格表现 MDN 。特殊情况下会出现循环 Maximum recursive updates。

具体详见关联 issues

Solution

替换 Inject 方案,调整 span 算法,提高性能的同时更简单的实现。
与之前的版本表现基本一致无特别破坏性变动。

How is the change tested?

Changelog

Component Changelog(CN) Changelog(EN) Related issues
Descriptions 修复 span 分配布局的错误使其更遵循用户配置 fixes the issue related to the layout distribution of span Closes #3072, Closes #3070, Closes #2962, Closes #2550, Closes #1685, Closes #2537

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others
    should be submitted to main branch)

Other information

Copy link

codesandbox bot commented Jan 6, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@oljc oljc merged commit 39b69d5 into arco-design:main Jan 7, 2025
2 of 4 checks passed
@oljc oljc deleted the fix-descriptions branch January 7, 2025 02:51
@oljc oljc added this to the 2.56.4 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment