Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php-cs-fixer job is failing from PRs #29

Open
xHeaven opened this issue Dec 29, 2024 · 1 comment
Open

php-cs-fixer job is failing from PRs #29

xHeaven opened this issue Dec 29, 2024 · 1 comment

Comments

@xHeaven
Copy link

xHeaven commented Dec 29, 2024

The php-cs-fixer job is failing if it runs from a remote branch and finds issues - for example, a PR with wrong indenting. See here.

@stancl
Copy link
Member

stancl commented Dec 29, 2024

Yeah, this is known. It's the same in our other repos based on our package template. Tried to solve it in the past but it was a bit painful so it's on hold now. Essentially the CI workflow passes if the user submitting the PR has write perms to the repo, not otherwise. It is still informative in terms of whether php-cs-fixer passed or not, it just doesn't auto fix PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants