Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.20.4] [All] Exception when removing duplicates modules on windows #24

Open
Edouard127 opened this issue Aug 18, 2024 · 2 comments · May be fixed by #25
Open

[1.20.4] [All] Exception when removing duplicates modules on windows #24

Edouard127 opened this issue Aug 18, 2024 · 2 comments · May be fixed by #25

Comments

@Edouard127
Copy link

Recently, a new error arose on Architectury transformer 5.2.87
The suspected commit is b79d342, this is the one that introduced the method to remove duplicate modules on SecureModuleFinder

Full stacktrace https://mclo.gs/jiHmNgx

Additional info:

  • Forge 49.1.4
  • Architectury Loom 1.7.412
  • Java 17
  • Windows 10
@Edouard127
Copy link
Author

Edouard127 commented Aug 20, 2024 •
edited
Loading

The issue is actually caused by the OS path separator
On linux the separator is / whereas windows has \\

@Edouard127 Edouard127 changed the title [1.20.4] [Forge] Exception when removing duplicates modules [1.20.4] [Forge] Exception when removing duplicates modules on windows Aug 22, 2024
@Userhunt
Copy link

Same for fabric

@Edouard127 Edouard127 linked a pull request Aug 29, 2024 that will close this issue
Open
@Edouard127 Edouard127 changed the title [1.20.4] [Forge] Exception when removing duplicates modules on windows [1.20.4] [All] Exception when removing duplicates modules on windows Aug 29, 2024
@Edouard127 Edouard127 mentioned this issue Sep 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Userhunt @Edouard127