Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ThreadLocal clean up & onError #1

Open
peterjurkovic opened this issue Nov 13, 2019 · 0 comments
Open

ThreadLocal clean up & onError #1

peterjurkovic opened this issue Nov 13, 2019 · 0 comments

Comments

@peterjurkovic
Copy link

Hi there,
I have two questions:

  1. Why is not being populated a MDC context also onError operator?
    https://github.com/archie-swif/webflux-mdc/blob/master/src/main/java/com/example/webfluxmdc/MdcContextLifter.java#L54

  2. How about ThreadLocal clean up? When it gets cleaned? Should not be called MDC.clean() after the operator invocation?

try {
 coreSubscriber.onNext(obj);
} finally {
MDC.clean();
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peterjurkovic