Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macro directory PopOut, upgrade module for v11 #26

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix macro directory PopOut, upgrade module for v11 #26

wants to merge 3 commits into from

Conversation

Forien
Copy link

@Forien Forien commented Feb 1, 2024 •
edited
Loading

Changelog

  1. Fixed right clicking on macro tab muliplying instead of popping out (video below)
  2. Updated code for Foundry v11, including change from deprecated SidebarDirectory to DocumentDirectory
  3. Removed needless getters and other practically useless code
  4. Removed legacy support (since we are moving away from deprecated class anyway)
  5. Set new minimum Foundry version and removed legacy attributes from manifest

Directory multiplication bug due to disabled popout

Resolves #22

@p4535992
Copy link

p4535992 commented May 5, 2024

@arcanistzed a reminder for this

@arcanistzed
Copy link
Owner

Screenshot_20240505-061746.png

Screenshot_20240505-061852.png

Screenshot_20240505-061902.png

Screenshot_20240505-061918.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Popout Duplicating in Sidebar/Not Being able to Move Outside Sidebar
3 participants
@Forien @p4535992 @arcanistzed